Remove 'fail' argument from TruffleHog workflow, in workflow#5
Merged
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2896207 in 48 seconds. Click for details.
- Reviewed
10lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/trufflehog.yml:35
- Draft comment:
Removing '--fail' flag changes the scan behavior so the workflow won't fail on detecting issues. Confirm this is the intended behavior and document the rationale if necessary. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% The comment is about a real change in the diff. It's pointing out a potentially significant change in behavior - the scan will no longer fail the workflow when issues are found. However, the comment asks for confirmation and documentation of rationale, which violates our rules about asking for confirmations or explanations. The change could be a security concern since it makes the secret scanning workflow non-blocking. Maybe we should keep the comment due to security implications? While security is important, our rules clearly state not to ask for confirmations or explanations. If the author wanted the workflow to be non-blocking, we should trust their judgment. Delete the comment because it violates our rule about asking for confirmations and explanations of intent, even though it correctly identifies a behavior change.
Workflow ID: wflow_4qq65p4F31zALqAP
You can customize 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Remove '--fail' argument from TruffleHog workflow in
.github/workflows/trufflehog.yml.--failargument fromextra_argsin TruffleHog step in.github/workflows/trufflehog.yml.This description was created by
for 2896207. You can customize this summary. It will automatically update as commits are pushed.